No longer infer insufficient LAPACK from libRlapack use #483
+8
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes the inference of insufficient LAPACK from libRlapack usage by commenting out or removing all code related to the ARMA_CRIPPLED_LAPACK flag. The change is based on the assumption that R's internal libRlapack library is now complete for RcppArmadillo's purposes, including for complex variables.
- Removes
ARMA_CRIPPLED_LAPACKconfiguration from header template - Comments out LAPACK detection logic in configure scripts
- Eliminates the AC_SUBST substitution for ARMA_LAPACK
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| inst/include/RcppArmadillo/config/RcppArmadilloConfigGenerated.h.in | Removes the ARMA_CRIPPLED_LAPACK conditional compilation block |
| configure.ac | Comments out the arma_lapack variable assignments and AC_SUBST call |
| configure | Comments out the generated configure script logic for LAPACK detection |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
eddelbuettel
force-pushed
the
feature/simpler_lapack_setup
branch
from
2b49dd6 to
4525749
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #481
We no longer pass down whether R uses its internal
libRlapacklibrary. This library uses to be insufficient, hence the need for a flag but should now be complete for our purposes, including for complex variables.